[SPIRV] Handle associated counters for RWStructuredBuffer in base classes#7880
Merged
Conversation
…sses This commit fixes an issue where the associated counters for RWStructuredBuffer were not correctly handled when the buffer was a member of a base class. The changes include: - Updating to recursively traverse base classes and nested structs to find associated counter variables. - Modifying to correctly generate instructions for accessing members of base classes. - Adding a new test case to verify the correct handling of counter variables in base classes. - Updating existing tests to reflect the changes in generation. Fixes microsoft#7787
luciechoi
approved these changes
Nov 11, 2025
Keenuts
reviewed
Nov 12, 2025
s-perron
force-pushed
the
i7787_counter_var
branch
from
3127cd5 to
abacc0c
Compare
s-perron
force-pushed
the
i7787_counter_var
branch
from
abacc0c to
500c1ac
Compare
Keenuts
approved these changes
Nov 14, 2025
Collaborator
|
I think this change may have caused some issues with base classes in cbuffers - I've filed #7968 about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the associated counters for RWStructuredBuffer were not correctly handled when the buffer was a member of a base class.
The changes include:
Fixes #7787